Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): apply vite-node's wrapper only to executed files #5642

Merged

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Apr 30, 2024

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit c8162d4
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6632671be88e5900083a6cb3

@AriPerkkio AriPerkkio force-pushed the fix/v8-coverage-wrapper-length branch from d1b4dd4 to c8162d4 Compare May 1, 2024 16:00
@AriPerkkio AriPerkkio marked this pull request as ready for review May 1, 2024 16:09
@AriPerkkio AriPerkkio requested a review from sheremet-va May 1, 2024 16:09
@AriPerkkio
Copy link
Member Author

/ecosystem-ci run

@vitest-ecosystem-ci
Copy link

vitest-ecosystem-ci bot commented May 1, 2024

📝 Ran ecosystem CI: Open

suite result
aria-live-capture ✅ success
nuxt ❌ failure
nuxt-test-utils ❌ failure
elk ❌ failure
effect ✅ success
zustand ✅ success
vue ✅ success
vite ✅ success
vitest-vscode ✅ success
vitest-sonar-reporter ✅ success
vitest-github-actions-reporter ✅ success
vitest-browser-simple ✅ success
vitest-coverage-large ✅ success
vitest-reporters-large ✅ success

@sheremet-va sheremet-va merged commit c9883f3 into vitest-dev:main May 2, 2024
19 checks passed
@AriPerkkio AriPerkkio deleted the fix/v8-coverage-wrapper-length branch May 2, 2024 09:02
github-merge-queue bot referenced this pull request in camunda/camunda May 3, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [vitest](https://togithub.com/vitest-dev/vitest)
([source](https://togithub.com/vitest-dev/vitest/tree/HEAD/packages/vitest))
| [`1.5.3` ->
`1.6.0`](https://renovatebot.com/diffs/npm/vitest/1.5.3/1.6.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/vitest/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vitest/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vitest/1.5.3/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vitest/1.5.3/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vitest-dev/vitest (vitest)</summary>

###
[`v1.6.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.6.0)

[Compare
Source](https://togithub.com/vitest-dev/vitest/compare/v1.5.3...v1.6.0)

#####    🚀 Features

- Support standalone mode  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5565](https://togithub.com/vitest-dev/vitest/issues/5565)
[<samp>(bdce0)</samp>](https://togithub.com/vitest-dev/vitest/commit/bdce0a29)
- Custom "snapshotEnvironment" option  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5449](https://togithub.com/vitest-dev/vitest/issues/5449)
[<samp>(30f72)</samp>](https://togithub.com/vitest-dev/vitest/commit/30f728bc)
- **benchmark**: Support comparing benchmark result  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) and
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5398](https://togithub.com/vitest-dev/vitest/issues/5398)
[<samp>(f8d3d)</samp>](https://togithub.com/vitest-dev/vitest/commit/f8d3d22e)
- **browser**: Allow injecting scripts  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5656](https://togithub.com/vitest-dev/vitest/issues/5656)
[<samp>(21e58)</samp>](https://togithub.com/vitest-dev/vitest/commit/21e58bd8)
- **reporter**: Support `includeConsoleOutput` and `addFileAttribute` in
junit  -  by [@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[https://github.com/vitest-dev/vitest/issues/5659](https://togithub.com/vitest-dev/vitest/issues/5659)
[<samp>(2f913)</samp>](https://togithub.com/vitest-dev/vitest/commit/2f913222)
- **ui**: Sort items by file name  -  by
[@&#8203;btea](https://togithub.com/btea) in
[https://github.com/vitest-dev/vitest/issues/5652](https://togithub.com/vitest-dev/vitest/issues/5652)
[<samp>(1f726)</samp>](https://togithub.com/vitest-dev/vitest/commit/1f7268fa)

#####    🐞 Bug Fixes

- Keep order of arguments for .each in custom task collectors  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5640](https://togithub.com/vitest-dev/vitest/issues/5640)
[<samp>(7d57c)</samp>](https://togithub.com/vitest-dev/vitest/commit/7d57c116)
- Call `resolveId('vitest')` after `buildStart`  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[https://github.com/vitest-dev/vitest/issues/5646](https://togithub.com/vitest-dev/vitest/issues/5646)
[<samp>(f5faf)</samp>](https://togithub.com/vitest-dev/vitest/commit/f5faf423)
- Hash the name of the file when caching  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5654](https://togithub.com/vitest-dev/vitest/issues/5654)
[<samp>(c9e68)</samp>](https://togithub.com/vitest-dev/vitest/commit/c9e68ced)
- Don't panic on empty files in node_modules  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va)
[<samp>(40c29)</samp>](https://togithub.com/vitest-dev/vitest/commit/40c299fe)
- Use `toJSON` for error serialization  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[https://github.com/vitest-dev/vitest/issues/5526](https://togithub.com/vitest-dev/vitest/issues/5526)
[<samp>(19a21)</samp>](https://togithub.com/vitest-dev/vitest/commit/19a21e49)
-   **coverage**:
- Exclude `*.test-d.*` by default  -  by
[@&#8203;MindfulPol](https://togithub.com/MindfulPol) in
[https://github.com/vitest-dev/vitest/issues/5634](https://togithub.com/vitest-dev/vitest/issues/5634)
[<samp>(bfe8a)</samp>](https://togithub.com/vitest-dev/vitest/commit/bfe8ad9d)
- Apply `vite-node`'s wrapper only to executed files  -  by
[@&#8203;AriPerkkio](https://togithub.com/AriPerkkio) in
[https://github.com/vitest-dev/vitest/issues/5642](https://togithub.com/vitest-dev/vitest/issues/5642)
[<samp>(c9883)</samp>](https://togithub.com/vitest-dev/vitest/commit/c9883f3e)
-   **vm**:
- Support network imports  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5610](https://togithub.com/vitest-dev/vitest/issues/5610)
[<samp>(103a6)</samp>](https://togithub.com/vitest-dev/vitest/commit/103a6002)

#####    🏎 Performance

- Improve performance of forks pool  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5592](https://togithub.com/vitest-dev/vitest/issues/5592)
[<samp>(d8304)</samp>](https://togithub.com/vitest-dev/vitest/commit/d8304bb4)
- Unnecessary rpc call when coverage is disabled  -  by
[@&#8203;AriPerkkio](https://togithub.com/AriPerkkio) in
[https://github.com/vitest-dev/vitest/issues/5658](https://togithub.com/vitest-dev/vitest/issues/5658)
[<samp>(c5712)</samp>](https://togithub.com/vitest-dev/vitest/commit/c571276a)

#####     [View changes on
GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.5.3...v1.6.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/camunda/zeebe).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage of types files can end up with a fatal error: Cannot read properties of undefined (reading 'endCol')
2 participants